Disable always return on HandleLoadNetModule

As of 1.4.x.x, these are used for more than just chat text and we need
to start handling them separately. The original check here would just
return true (handling the event) for any module that's not text. Now, we
need to actually do processing and check for exploits on these.
This commit is contained in:
Lucas Nicodemus 2020-05-17 23:47:16 -07:00
parent 926f97b49f
commit 12d40e98ad
No known key found for this signature in database
GPG key ID: A07BD9023D1664DB

View file

@ -3115,8 +3115,18 @@ namespace TShockAPI
private static bool HandleLoadNetModule(GetDataHandlerArgs args)
{
// Since this packet is never actually sent to us, every attempt at sending it can be considered as a liquid exploit attempt
return true;
// As of 1.4.x.x, this is now used for more things:
// NetCreativePowersModule
// NetCreativePowerPermissionsModule
// NetLiquidModule
// NetParticlesModule
// NetPingModule
// NetTeleportPylonModule
// NetTextModule
// I (particles) have disabled the original return here, which means that we need to
// handle this more. In the interm, this unbreaks parts of vanilla. Originally
// we just blocked this because it was a liquid exploit.
return false;
}
private static bool HandlePlaceTileEntity(GetDataHandlerArgs args)