diff --git a/TShockAPI/Commands.cs b/TShockAPI/Commands.cs index 020ad88f..99cb3620 100755 --- a/TShockAPI/Commands.cs +++ b/TShockAPI/Commands.cs @@ -2602,7 +2602,7 @@ namespace TShockAPI TShock.Groups.AddGroup(groupName, null, permissions, TShockAPI.Group.defaultChatColor); args.Player.SendSuccessMessage("The group was added successfully!"); } - catch (GroupExistsException e) + catch (GroupExistsException) { args.Player.SendErrorMessage("That group already exists!"); } diff --git a/TShockAPI/GetDataHandlers.cs b/TShockAPI/GetDataHandlers.cs index c746dbd1..fe5760ae 100755 --- a/TShockAPI/GetDataHandlers.cs +++ b/TShockAPI/GetDataHandlers.cs @@ -1379,6 +1379,8 @@ namespace TShockAPI string name = args.Data.ReadString(); byte hairDye = args.Data.ReadInt8(); BitsByte hideVisual = args.Data.ReadInt8(); + // We have to read in some values so we can read in sequence; but they aren't all used. + #pragma warning disable 0219 Color hairColor = new Color(args.Data.ReadInt8(), args.Data.ReadInt8(), args.Data.ReadInt8()); Color skinColor = new Color(args.Data.ReadInt8(), args.Data.ReadInt8(), args.Data.ReadInt8()); Color eyeColor = new Color(args.Data.ReadInt8(), args.Data.ReadInt8(), args.Data.ReadInt8()); @@ -1386,6 +1388,7 @@ namespace TShockAPI Color underShirtColor = new Color(args.Data.ReadInt8(), args.Data.ReadInt8(), args.Data.ReadInt8()); Color pantsColor = new Color(args.Data.ReadInt8(), args.Data.ReadInt8(), args.Data.ReadInt8()); Color shoeColor = new Color(args.Data.ReadInt8(), args.Data.ReadInt8(), args.Data.ReadInt8()); + #pragma warning restore 0219 var difficulty = args.Data.ReadInt8(); if (OnPlayerInfo(playerid, hair, male, difficulty, name)) @@ -2754,7 +2757,11 @@ namespace TShockAPI int flag = args.Data.ReadByte(); int tileX = args.Data.ReadInt16(); int tileY = args.Data.ReadInt16(); + // We have to read in some values so we can read in sequence; but they aren't all used. + #pragma warning disable 0219 int style = args.Data.ReadInt16(); + #pragma warning restore 0219 + if (OnTileKill(tileX, tileY)) return true; @@ -2870,11 +2877,14 @@ namespace TShockAPI var x = args.Data.ReadInt16(); var y = args.Data.ReadInt16(); var b = args.Data.ReadInt8(); + // Hide warning for not using name + #pragma warning disable 0219 var name = ""; if (b != 0 && b <= 20) name = args.Data.ReadString(); + #pragma warning restore 0219 args.Player.ActiveChest = id; if (TShock.CheckTilePermission(args.Player, x, y) && TShock.Config.RegionProtectChests) @@ -2933,7 +2943,9 @@ namespace TShockAPI var id = args.Data.ReadInt16(); var x = args.Data.ReadInt16(); var y = args.Data.ReadInt16(); + #pragma warning disable 0219 var text = args.Data.ReadString(); + #pragma warning restore 0219 if (OnSignEvent(id, x, y)) return true; @@ -3129,7 +3141,10 @@ namespace TShockAPI var id = args.Data.ReadInt8(); var direction = (byte)(args.Data.ReadInt8() - 1); var dmg = args.Data.ReadInt16(); + // Ignore text not being read + #pragma warning disable 0219 var text = args.Data.ReadString(); + #pragma warning restore 0219 var bits = (BitsByte)args.Data.ReadInt8(); var pvp = bits[0]; var crit = bits[1]; @@ -3553,10 +3568,13 @@ namespace TShockAPI private static bool HandleDoorUse(GetDataHandlerArgs args) { + // close and dir aren't read; ignore warnings for them + #pragma warning disable 0219 var close = args.Data.ReadByte(); var x = args.Data.ReadInt16(); var y = args.Data.ReadInt16(); var dir = args.Data.ReadByte() == 0 ? -1 : 1; + #pragma warning restore 0219 if (x >= Main.maxTilesX || y >= Main.maxTilesY || x < 0 || y < 0) // Check for out of range return true;