themaster1970sf/TShock
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Removed unimportant messages from OnSecondUpdate()

Browse source 
Removed check ignores failed and player disabled for
not being logged in whilst SSC is enabled console messages, as
they are incessant in larger servers.

The messages are not informative as they are not reasonably
actionable by the console, and there is no point in spamming
server operators about such issues.
This commit is contained in:
Tyler Watson 2015-11-26 19:13:08 +10:00
parent 556a5ca560
commit 4167a9b627
2 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

20
TShockAPI/TSPlayer.cs
View file

@ -875,13 +875,23 @@ namespace TShockAPI
} }
} }
var trace = new StackTrace(); /*
StackFrame frame = null; * Calling new StackTrace() is incredibly expensive, and must be disabled
frame = trace.GetFrame(1); * in release builds. Use a conditional call instead.
if (frame != null && frame.GetMethod().DeclaringType != null) */
TShock.Log.Debug(frame.GetMethod().DeclaringType.Name + " called Disable()."); LogStackFrame();
} }
[Conditional("DEBUG")]
private void LogStackFrame()
{
var trace = new StackTrace();
StackFrame frame = null;
frame = trace.GetFrame(1);
if (frame != null && frame.GetMethod().DeclaringType != null)
TShock.Log.Debug(frame.GetMethod().DeclaringType.Name + " called Disable().");
}
public virtual void Whoopie(object time) public virtual void Whoopie(object time)
{ {
var time2 = (int) time; var time2 = (int) time;

4
TShockAPI/TShock.cs
View file

@ -966,7 +966,7 @@ namespace TShockAPI
{ {
if (CheckIgnores(player)) if (CheckIgnores(player))
{ {
player.Disable("not being logged in while SSC is enabled", flags); player.Disable(flags: flags);
} }
else if (Itembans.ItemIsBanned(player.TPlayer.inventory[player.TPlayer.selectedItem].name, player)) else if (Itembans.ItemIsBanned(player.TPlayer.inventory[player.TPlayer.selectedItem].name, player))
{ {
@ -1046,7 +1046,7 @@ namespace TShockAPI
if (CheckIgnores(player)) if (CheckIgnores(player))
{ {
player.Disable("check ignores failed in OnSecondUpdate()", flags); player.Disable(flags: flags);
} }
else if (Itembans.ItemIsBanned(player.TPlayer.inventory[player.TPlayer.selectedItem].name, player)) else if (Itembans.ItemIsBanned(player.TPlayer.inventory[player.TPlayer.selectedItem].name, player))
{ {