themaster1970sf/TShock
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Change null check to return true in HandlePlayerUpdate

Browse source 
After confirming with @QuiCM on this, we couldn't figure out why
this was set to false in the first place. As a result, we changed
it to true to conform with usual logic (bad stuff? reject it.).
This commit is contained in:
Lucas Nicodemus 2017-12-11 00:17:58 -07:00
parent 9b8aaceb12
commit 4b08d61673
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
TShockAPI/GetDataHandlers.cs
View file

@ -2076,10 +2076,7 @@ namespace TShockAPI
{ {
if (args.Player == null || args.TPlayer == null || args.Data == null) if (args.Player == null || args.TPlayer == null || args.Data == null)
{ {
// Is this really the best option? return true;
// If we're getting a packet that doesn't have a player or a TPlayer or data...
// Should we really let it through?
return false;
} }
byte plr = args.Data.ReadInt8(); byte plr = args.Data.ReadInt8();