themaster1970sf/TShock
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Move GiveItemsDirectly config item to tshock config

Browse source 
Due to an issue that stops the SSC config persister thing from working,
I moved the config item that's new back to the config file. I tried
applying the patches from
https://github.com/Pryaxis/TShock/pull/2354/commits but these didn't
actually resolve the issue. I'm keeping the commits here but I'm not
sure they help.

The core problem is this: if you add a new config file item to the ssc
config, the ssc config is overwritten with the default config items
instead of being merged automatically with the new items. This is a
critical issue as it means that SSC is disabled on all servers that had
it enabled and results in "data misplacement" which is alarming enough
to cause users to think they had data loss, which is not ideal.

Until the issue with the SSC config is resolved, I'm not willing or
confident to change it.
This commit is contained in:
Lucas Nicodemus 2022-10-31 16:18:39 -07:00
parent 05fe6c905f
commit 61e36d0abd
No known key found for this signature in database
6 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
docs/ssc-config.md
View file

@ -3,11 +3,6 @@ Enable server side characters, causing client data to be saved on the server ins
* **Field type**: `Boolean`
* **Default**: `False`
## GiveItemsDirectly
If set to true, items given to players will be inserted directly into their inventory. Requires SSC. Otherwise, items given to players will spawn as dropped items.
* **Field type**: `Boolean`
* **Default**: `False`
## LogonDiscardThreshold
Time, in milliseconds, to disallow discarding items after logging in when ServerSideCharacters is ON.
* **Field type**: `Int32`
@ -26,7 +21,7 @@ The starting default health for new players when SSC is enabled.
## StartingInventory
The starting default inventory for new players when SSC is enabled.
* **Field type**: `List`1`
* **Default**: `System.Collections.Generic.List\`1[TShockAPI.NetItem]`
* **Default**: `System.Collections.Generic.List`1[TShockAPI.NetItem]`
## StartingMana
The starting default mana for new players when SSC is enabled.