From 6856c867dd99efe31bdd4e1a8ea43e7ec9e41613 Mon Sep 17 00:00:00 2001 From: Lucas Nicodemus Date: Sun, 23 May 2021 03:21:56 -0700 Subject: [PATCH] Use correct value to read usingBiomeTorches in GDH This fixes a ridiculous typo in GetDataHandlers where we were setting the UsingBiomeTorches flag based on having unlocked biome torches, rather than actually being used. Thanks to @Arthri for the tip! --- CHANGELOG.md | 1 + TShockAPI/GetDataHandlers.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 781c0e7d..523f96f2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ This is the rolling changelog for TShock for Terraria. Use past tense when addin * If there is no section called "Upcoming changes" below this line, please add one with `## Upcoming changes` as the first line, and then a bulleted item directly after with the first change. ## Upcoming changes +* Fixed ridiculous typo in `GetDataHandlers` which caused TShock to read the wrong field in the packet for `usingBiomeTorches`. (@hakusaro, @Arthri) ## TShock 4.5.3 * Added permissions for using Teleportation Potions, Magic Conch, and Demon Conch. (@drunderscore) diff --git a/TShockAPI/GetDataHandlers.cs b/TShockAPI/GetDataHandlers.cs index b2c75b76..c24a95b0 100644 --- a/TShockAPI/GetDataHandlers.cs +++ b/TShockAPI/GetDataHandlers.cs @@ -2306,7 +2306,7 @@ namespace TShockAPI args.Player.TPlayer.hideMisc = hideMisc; args.Player.TPlayer.extraAccessory = extraSlot; args.Player.TPlayer.unlockedBiomeTorches = unlockedBiomeTorches; - args.Player.TPlayer.UsingBiomeTorches = unlockedBiomeTorches; + args.Player.TPlayer.UsingBiomeTorches = usingBiomeTorches; NetMessage.SendData((int)PacketTypes.PlayerInfo, -1, args.Player.Index, NetworkText.FromLiteral(args.Player.Name), args.Player.Index); return true;