From 76150e2500c6680d41d172ed4985860a71fcd81b Mon Sep 17 00:00:00 2001 From: Lucas Nicodemus Date: Wed, 13 May 2020 20:33:24 -0700 Subject: [PATCH] Provide warning message on invalid group command This fixes #1742 where users could run group commands that didn't exist and the server would silently fail rather than giving an error. --- CHANGELOG.md | 1 + TShockAPI/Commands.cs | 3 +++ 2 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 56beb046..e2c4f47c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -97,6 +97,7 @@ This is the rolling changelog for TShock for Terraria. Use past tense when addin * Add PlayerZone data handler and bouncer (@AxeelAnder) * Update sqlite binaries to 32bit 3.27.2 for Windows (@hakusaro) * Fix banned armour checks not clearing properly (thanks @tysonstrange) +* Added warning message on invalid group comand (@hakusaro, thanks to IcyPhoenix, nuLLzy & Cy on Discord) ## TShock 4.3.25 * Fixed a critical exploit in the Terraria protocol that could cause massive unpreventable world corruption as well as a number of other problems. Thanks to @bartico6 for reporting. Fixed by the efforts of @QuiCM, @hakusaro, and tips in the right directioon from @bartico6. diff --git a/TShockAPI/Commands.cs b/TShockAPI/Commands.cs index 123470a1..f8083b60 100644 --- a/TShockAPI/Commands.cs +++ b/TShockAPI/Commands.cs @@ -3240,6 +3240,9 @@ namespace TShockAPI } #endregion return; + default: + args.Player.SendErrorMessage("Invalid subcommand! Type {0}group help for more information on valid commands.", Specifier); + return; } } #endregion Group Management