From 0753e6d2136231d0c0b456891ad874d352be07f3 Mon Sep 17 00:00:00 2001 From: Leo Li Date: Sun, 23 Jul 2017 20:42:42 -0700 Subject: [PATCH 1/2] Add more HintPaths for OTAPI This will help msbuild to find missing libraries when create release with `/p:Configuration=Release`. With this patch, the searching order will be: - If OTAPI with same configuration found, use that. - Else if OTAPI with Release configuration found, use that. - Else use OTAPI with Debug configuration. --- TShockAPI/TShockAPI.csproj | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/TShockAPI/TShockAPI.csproj b/TShockAPI/TShockAPI.csproj index 9bf2ebd9..08e9323d 100644 --- a/TShockAPI/TShockAPI.csproj +++ b/TShockAPI/TShockAPI.csproj @@ -74,7 +74,9 @@ False - ..\TerrariaServerAPI\TerrariaServerAPI\bin\Debug\OTAPI.dll + ..\TerrariaServerAPI\TerrariaServerAPI\bin\Debug\OTAPI.dll + ..\TerrariaServerAPI\TerrariaServerAPI\bin\Release\OTAPI.dll + ..\TerrariaServerAPI\TerrariaServerAPI\bin\$(Configuration)\OTAPI.dll @@ -214,4 +216,4 @@ --> - \ No newline at end of file + From 6f8d795a65d0d553bcfc831d3b3aa9a6b41b3383 Mon Sep 17 00:00:00 2001 From: Lucas Nicodemus Date: Mon, 25 Sep 2017 12:28:25 -0600 Subject: [PATCH 2/2] Switch to msbuild commands Fixes #1494 --- scripts/create_release.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/create_release.py b/scripts/create_release.py index 3a25f76d..735c664c 100755 --- a/scripts/create_release.py +++ b/scripts/create_release.py @@ -145,7 +145,7 @@ def update_terraria_source(): def run_bootstrapper(): for build_config in ['Debug','Release'] : - mintaka = subprocess.Popen(['xbuild', './TerrariaServerAPI/TShock.4.OTAPI.sln', '/p:Configuration=' + build_config]) + mintaka = subprocess.Popen(['msbuild', './TerrariaServerAPI/TShock.4.OTAPI.sln', '/p:Configuration=' + build_config]) mintaka.wait() @@ -161,7 +161,7 @@ def run_bootstrapper(): if (bootstrapper_proc.returncode != 0): raise CalledProcessError(bootstrapper_proc.returncode) - tsapi_proc = subprocess.Popen(['xbuild', './TerrariaServerAPI/TerrariaServerAPI/TerrariaServerAPI.csproj', '/p:Configuration=' + build_config]) + tsapi_proc = subprocess.Popen(['msbuild', './TerrariaServerAPI/TerrariaServerAPI/TerrariaServerAPI.csproj', '/p:Configuration=' + build_config]) tsapi_proc.wait() @@ -169,8 +169,8 @@ def run_bootstrapper(): raise CalledProcessError(tsapi_proc.returncode) def build_software(): - release_proc = subprocess.Popen(['xbuild', './TShockAPI/TShockAPI.csproj', '/p:Configuration=Release']) - debug_proc = subprocess.Popen(['xbuild', './TShockAPI/TShockAPI.csproj', '/p:Configuration=Debug']) + release_proc = subprocess.Popen(['msbuild', './TShockAPI/TShockAPI.csproj', '/p:Configuration=Release']) + debug_proc = subprocess.Popen(['msbuild', './TShockAPI/TShockAPI.csproj', '/p:Configuration=Debug']) release_proc.wait() debug_proc.wait() if (release_proc.returncode != 0):