From 9209ac0b73c90d8d64aaf8d4e6e7fcfe2eb9243c Mon Sep 17 00:00:00 2001 From: Zack Date: Sun, 24 May 2020 04:19:00 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Lucas Nicodemus --- CHANGELOG.md | 2 +- TShockAPI/Bouncer.cs | 2 +- TShockAPI/TSPlayer.cs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c0074b8c..1505337c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ This is the rolling changelog for TShock for Terraria. Use past tense when addin * Update for OTAPI 2.0.0.36 and Terraria 1.4.0.4. (@hakusaro, @Patrikkk, @DeathCradle) * Fixed /wind command. (@AxeelAnder) * Fixed NPC buff bouncer. (@AxeelAnder) -* Fix fluid bombs. (@Olink) +* Fixed lava, wet, and honey bombs. (@Olink) ## TShock 4.4.0 (Pre-release 7 (Entangled)) * Fixed bed spawn issues when trying to remove spawn point in SSC. (@Olink) diff --git a/TShockAPI/Bouncer.cs b/TShockAPI/Bouncer.cs index afa5d6a3..a506d079 100644 --- a/TShockAPI/Bouncer.cs +++ b/TShockAPI/Bouncer.cs @@ -1303,7 +1303,7 @@ namespace TShockAPI } bool wasThereABombNearby = false; - +// The +/- 16 is compensation for maximum detonation distance, but it might be possible to drop to 5 and be conservative lock (args.Player.RecentlyCreatedProjectiles) { var keys = projectileCreatesLiquid.Where(k => k.Value == type).Select(k => k.Key); diff --git a/TShockAPI/TSPlayer.cs b/TShockAPI/TSPlayer.cs index 277e9b00..3d7deaae 100644 --- a/TShockAPI/TSPlayer.cs +++ b/TShockAPI/TSPlayer.cs @@ -765,8 +765,8 @@ namespace TShockAPI public int LastKilledProjectile = 0; /// - /// Keeps track of recently created projectiles by this player. TShock.cs OnSecondUpdate() removes from this in an async task. - /// Projectiles older than 5 seconds are purged from this collection as they are no longer "recent". + /// Keeps track of recently created projectiles by this player. TShock.cs OnSecondUpdate() removes from this in an async task. + /// Projectiles older than 5 seconds are purged from this collection as they are no longer "recent." /// internal List RecentlyCreatedProjectiles = new List();