From 987d9e793be45438c32215b23be03f2f3ecd0ec3 Mon Sep 17 00:00:00 2001 From: Zack Piispanen Date: Fri, 22 Jul 2011 17:33:59 -0400 Subject: [PATCH] fixed useless query for being useless. Added in code that checks the list of groups and not the db itself. TSDEV-49 --- TShockAPI/DB/GroupManager.cs | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/TShockAPI/DB/GroupManager.cs b/TShockAPI/DB/GroupManager.cs index 3fee53d4..8c8d0c45 100644 --- a/TShockAPI/DB/GroupManager.cs +++ b/TShockAPI/DB/GroupManager.cs @@ -131,27 +131,13 @@ namespace TShockAPI.DB if (group == "superadmin") return true; - - try - { - using (var com = database.CreateCommand()) - { - com.CommandText = "SELECT * FROM Grouplist WHERE GroupName=@groupname"; - com.AddParameter("@groupname", group); - using (var reader = com.ExecuteReader()) - { - while (reader.Read()) - if (reader.Get("GroupName") == group) - return true; - reader.Close(); - } - } - } - catch (Exception ex) + foreach (Group g in groups) { - Log.Error(ex.ToString()); + if (g.Name.Equals(group)) + return true; } + return false; }