From abeddd4c07affd4a796fbcd724fd167a69e779f2 Mon Sep 17 00:00:00 2001 From: CoderCow Date: Fri, 2 Aug 2013 10:43:43 +0200 Subject: [PATCH] Minor improvements. --- TShockAPI/Rest/Rest.cs | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/TShockAPI/Rest/Rest.cs b/TShockAPI/Rest/Rest.cs index 9f1bccf7..0aaa1ad4 100644 --- a/TShockAPI/Rest/Rest.cs +++ b/TShockAPI/Rest/Rest.cs @@ -200,27 +200,18 @@ namespace Rests RestCommand cmd, RestVerbs verbs, IParameterCollection parms, bool includeToken = true ) { StringBuilder requestBuilder = new StringBuilder(cmd.UriTemplate); - if (parms.Count > 0) + char separator = '?'; + foreach (IParameter paramImpl in parms) { - bool isFirstParam = true; - foreach (IParameter paramImpl in parms) - { - Parameter param = (paramImpl as Parameter); - if (param == null || (!includeToken && param.Name.Equals("token", StringComparison.InvariantCultureIgnoreCase))) - continue; + Parameter param = (paramImpl as Parameter); + if (param == null || (!includeToken && param.Name.Equals("token", StringComparison.InvariantCultureIgnoreCase))) + continue; - if (!isFirstParam) - requestBuilder.Append('&'); - else - { - requestBuilder.Append('?'); - isFirstParam = false; - } - - requestBuilder.Append(param.Name); - requestBuilder.Append('='); - requestBuilder.Append(param.Value); - } + requestBuilder.Append(separator); + requestBuilder.Append(param.Name); + requestBuilder.Append('='); + requestBuilder.Append(param.Value); + separator = '&'; } return requestBuilder.ToString();