themaster1970sf/TShock
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Add two more guidelines to contributing

Browse source 
Some of these were implied rules not listed, and have been fixed.
This commit is contained in:
Lucas Nicodemus 2015-03-17 16:46:41 -06:00
parent 4513d5b4ac
commit e56561b689
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CONTRIBUTING.md
View file

@ -31,6 +31,9 @@ These guidelines are to be followed by all developers with commit level access t
- __Do not force push the repo__, or you will be removed.
- __Do not revert commits__, unless you have sign-off from one other developer (the two-man rule), or you will be removed.
- __This is not a meritocracy.__
- Deprecation of a function guarantees that it will exist in the given release, but may be removed, at any time following, from subsequent releases without further warning. Warning should be given in the release thread prior to it going live.
- Updates should be discussed, via pull request of a version tick, prior to release. Only after consensus from active contributing community members has been given can a release happen.
- Breaking API changes (excluding removal of already deprecated and warned code) should be forewarned with a one week notice on the forums, which may be given at any time prior to release (as soon as a pull request for a version push has been made, an update can be warned).
#### Pull Request Acceptance Guidelines