themaster1970sf/TShock
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Apply suggestions from code review

Browse source 
Co-authored-by: Lucas Nicodemus <shank@shanked.me>
This commit is contained in:
Zack 2020-05-24 04:19:00 -04:00 • committed by GitHub
parent 3b0c5f7775
commit 9209ac0b73
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -6,7 +6,7 @@ This is the rolling changelog for TShock for Terraria. Use past tense when addin
* Update for OTAPI 2.0.0.36 and Terraria 1.4.0.4. (@hakusaro, @Patrikkk, @DeathCradle) * Update for OTAPI 2.0.0.36 and Terraria 1.4.0.4. (@hakusaro, @Patrikkk, @DeathCradle)
* Fixed /wind command. (@AxeelAnder) * Fixed /wind command. (@AxeelAnder)
* Fixed NPC buff bouncer. (@AxeelAnder) * Fixed NPC buff bouncer. (@AxeelAnder)
* Fix fluid bombs. (@Olink) * Fixed lava, wet, and honey bombs. (@Olink)
## TShock 4.4.0 (Pre-release 7 (Entangled)) ## TShock 4.4.0 (Pre-release 7 (Entangled))
* Fixed bed spawn issues when trying to remove spawn point in SSC. (@Olink) * Fixed bed spawn issues when trying to remove spawn point in SSC. (@Olink)

2
TShockAPI/Bouncer.cs
View file

@ -1303,7 +1303,7 @@ namespace TShockAPI
} }
bool wasThereABombNearby = false; bool wasThereABombNearby = false;
// The +/- 16 is compensation for maximum detonation distance, but it might be possible to drop to 5 and be conservative
lock (args.Player.RecentlyCreatedProjectiles) lock (args.Player.RecentlyCreatedProjectiles)
{ {
var keys = projectileCreatesLiquid.Where(k => k.Value == type).Select(k => k.Key); var keys = projectileCreatesLiquid.Where(k => k.Value == type).Select(k => k.Key);

4
TShockAPI/TSPlayer.cs
View file

@ -765,8 +765,8 @@ namespace TShockAPI
public int LastKilledProjectile = 0; public int LastKilledProjectile = 0;
/// <summary> /// <summary>
/// Keeps track of recently created projectiles by this player. TShock.cs OnSecondUpdate() removes from this in an async task. /// Keeps track of recently created projectiles by this player. TShock.cs OnSecondUpdate() removes from this in an async task.
/// Projectiles older than 5 seconds are purged from this collection as they are no longer "recent". /// Projectiles older than 5 seconds are purged from this collection as they are no longer "recent."
/// </summary> /// </summary>
internal List<TShockAPI.GetDataHandlers.ProjectileStruct> RecentlyCreatedProjectiles = new List<TShockAPI.GetDataHandlers.ProjectileStruct>(); internal List<TShockAPI.GetDataHandlers.ProjectileStruct> RecentlyCreatedProjectiles = new List<TShockAPI.GetDataHandlers.ProjectileStruct>();