Commit graph

277 commits

Author SHA1 Message Date
Lucas Nicodemus
c62fca5353 Merge remote-tracking branch 'deathcradle/otapi3' into otapi3 2021-12-07 21:06:48 -08:00
Zoom L1
5230598ba3
Comments updated 2021-12-04 10:37:16 +07:00
Zoom L1
77ded28826
Corrected customDeathReason in OnPlayerDamage
Previously it was called for absolutely any damage from the player.
2021-12-02 22:13:25 +07:00
AkjaHAsLk1IALk0MasH
823293ed43 Updated code comments 2021-12-02 10:03:36 +07:00
AkjaHAsLk1IALk0MasH
a00512fcf4 Added protection to OnPlayerDamage 2021-11-30 21:14:53 +07:00
AkjaHAsLk1IALk0MasH
cdeec8aa04 Added protection in OnKillMe 2021-11-30 20:53:19 +07:00
AkjaHAsLk1IALk0MasH
df5c118055 Added comments to help other developers understand what I used and why 2021-11-30 14:36:19 +07:00
AkjaHAsLk1IALk0MasH
77032ccbea Renamed value in config 2021-11-30 14:23:49 +07:00
AkjaHAsLk1IALk0MasH
1a62d1dfed Added ai[0] check 2021-11-30 14:22:41 +07:00
AkjaHAsLk1IALk0MasH
6cec7e71cd Fixed the ability to spawn Zenith projectile with non-original items. 2021-11-28 15:35:50 +07:00
Lucas Nicodemus
0751f0cb5a Merge remote-tracking branch 'agaspace/general-devel' into general-devel 2021-11-27 17:15:44 -08:00
Luke
cec53c780f Merge branch 'general-devel' into otapi3 2021-11-27 17:53:28 +10:00
AkjaHAsLk1IALk0MasH
76b0d9e563 Removed unnecessary code comments. 2021-11-27 11:59:49 +07:00
AkjaHAsLk1IALk0MasH
606b9e43d7 Fixed the minimum value that made the "Bouncer" not work properly 2021-11-27 11:57:48 +07:00
Zoom L1
246c67a622
Updated the dictionaries. 2021-11-27 09:34:14 +07:00
Zoom L1
f11ffd2b91
Fixed the maximum and minimum values.
Co-authored-by: Arthri <41360489+Arthri@users.noreply.github.com>
2021-11-27 09:30:52 +07:00
AkjaHAsLk1IALk0MasH
bf605a2127 Added "Bouncer," which prohibits the creation of large projectiles. 2021-11-27 00:00:55 +07:00
Stargazing Koishi
db8d56cba7
Update BuffId typo 2021-11-26 06:54:56 -08:00
Stargazing Koishi
2217d63dc7
Update new buffs for NPC
The new TentacleSpike buff is allowed
2021-11-26 06:52:30 -08:00
Arthri
a1eaf285cd Merge remote-tracking branch 'parent/general-devel' into fix-invalid-place-style 2021-11-24 09:21:40 +08:00
Luke
8edd0393e5 Initial OTAPI3 port
TODO: sqlite
2021-11-23 20:49:41 +10:00
Lucas Nicodemus
f523d38300 Check RegionProtectGemLocks before enforcing perms
Fixes #2485. Bouncer now checks to ensure that RegionProtectGemLocks is
enabled before attempting to reject changes from gem locks from players
that don't have build permissions.
2021-11-20 18:19:47 -08:00
Arthri
d1459bb1ba Fix spaghetti one liner 2021-08-28 10:42:19 +08:00
Arthri
01d551aa30 Clarify multi-block tiles 2021-08-18 18:39:53 +08:00
Arthri
638b7cc54f Remove multiblock tiles 2021-08-18 17:39:28 +08:00
Arthri
8c5e7b4d47 Polish docs 2021-08-18 17:09:58 +08:00
Arthri
307ff79170 This isnt XML 2021-08-17 23:42:01 +08:00
Arthri
16451ec0e9 Complete docs and polish 2021-08-17 23:41:23 +08:00
Arthri
96f26be50b Complete correctors 2021-08-17 23:11:22 +08:00
Arthri
265cd2012f Transfer checks to a dictionary 2021-08-17 22:37:49 +08:00
Lucas Nicodemus
7b4042bf77 Merge branch 'general-devel' into fix-invalid-place-style 2021-08-16 16:10:41 -07:00
Chris
288698ce42 Some refactoring for variable naming & code flow 2021-08-16 22:14:02 +09:30
Arthri
ab30f5da70 Explain conditions in booster track check 2021-07-29 07:55:15 +08:00
Arthri
ca31a15be9 Add helper method for getting max placeStyle 2021-07-25 16:29:48 +08:00
Arthri
fd3e857f06 Declare BiomeTorchPlaceStyle's purpose 2021-07-25 14:12:17 +08:00
Arthri
de22400b3f Biome Torch check is suppose to check for 0 2021-07-25 14:06:47 +08:00
Arthri
8004b3f079 Declare how biome torch works 2021-07-25 13:55:56 +08:00
Killia0
9b249d72a8
Merge branch 'general-devel' into upstream-general-devel 2021-07-24 19:48:54 -04:00
Arthri
a1b7556d3a Simplify booster track check 2021-07-22 10:44:17 +08:00
Arthri
74197bd71b Add comment describing right booster track check 2021-07-22 10:43:23 +08:00
Arthri
c616d1cade Add comment describing biome torch correction code 2021-07-22 10:39:19 +08:00
Arthri
871f6babcc Fix issues 2021-07-19 15:45:14 +08:00
Arthri
b63b50bb3e Rename torchPlaceStyle -> correctedPlaceStyle 2021-07-19 14:06:43 +08:00
Arthri
ea180347cb Fix can't place >>> Booster Track 2021-07-19 14:05:58 +08:00
Arthri
9182b3b2be Fix invalid place style exploit 2021-07-19 13:48:06 +08:00
Arthri
fcccfc07e8 Fix invalid torch place style exploit 2021-07-19 13:38:40 +08:00
Killia0
154bee58f1 Typo fixes on comments/strings
My first PR contribution to TShock is spellcheck huh, frankly I don't know why but hey I could spare the time for this and caught some stuff.
2021-07-16 14:53:37 -04:00
James Puleo
ef603f61a8
Consistently use TilePlacementValid and SendTileSquare in Bouncer.
There are 3 different ways Bouncer uses these:
- Not checking `TilePlacementValid` at all.
- Checking `TilePlacementValid`, rejecting, but then doing a
  `SendTileSquare` to that player.
- Checking `TilePlacementValid`, rejecting. _(this is what we should
  always be doing)_

Not checking `TilePlacementValid` can allow for placement outside of the
world (unknown results), and checking `TilePlacementValid` and sending a
`SendTileSquare` on rejection causes the server to try to frame that
square. In the case of invalid coordinates (negative), framing takes
much longer than expected.
2021-07-10 00:10:45 -04:00
Lucas Nicodemus
89555beb73 Revert "Revert "Merge branch 'patch-28' into general-devel""
This reverts commit 258b21dddb.
2021-05-29 17:58:57 -07:00
Lucas Nicodemus
be2b817abd Merge remote-tracking branch 'moist/patch-28' into general-devel 2021-05-28 20:24:51 -07:00