Commit graph

3661 commits

Author SHA1 Message Date
White
6050f23a01 Merge pull request #1288 from Patrikkk/general-devel
Fix #1287 | Quickstack to nearby chests issue
2016-09-25 20:05:17 +09:30
Patrikk
d77f363157 Fix #1287 | Quickstack to nearby chests issue
CheckRangePermission accepts coordinate which is divided by 16.
The Position variable which is passed in ForceItemIntoChestEventArgs is
multiplied by 16.
(To be more exact. `new Vector2((float)(Main.chest[i].x * 16 + 16),
(float)(Main.chest[i].y * 16 + 16))`)
The + 16 is there to get the middle of the player so it can make an
accurate check when checking distance between chest and player.
So I'm not really sure if the Position arg should be even passed in the
eventarg.

Anyway, CheckRangePermission always returned true because of the above,
and handled the event, so players could never quickstack into nearby,
unless they had RangeChecks off.
"True if the player should not be able to place the tile." (In our case,
stack items into chest)

Why doesn't CheckRangePermission contain a check on an actual range
permission of the player's group? So groups with the permission could
bypass the check.
Just wondering if there is any legit reason for that.
2016-09-25 02:07:15 +02:00
Lucas Nicodemus
70565da77f A bunch of random bs 2016-09-24 12:34:42 -06:00
White
0a8a6a2df2 Version 4.3.18 2016-09-23 18:52:00 +09:30
White
b19ad19f3a Updated CHANGELOG.md 2016-09-23 18:51:27 +09:30
White
36343dd8e7 Add a sandstorm command 2016-09-22 19:13:50 +09:30
White
9520e7e782 Update submodule for sandstorms 2016-09-22 19:12:48 +09:30
Rodrigo
db11897ed5 Merge pull request #1271 from ProfessorXZ/itemdrop-fix
Fixed item duplication issues
2016-09-19 13:33:04 +01:00
Rodrigo
d48300fe31 Merge pull request #1283 from ProfessorXZ/wind-fix
Fixed UI issues caused by setting wind speed to high values
2016-09-19 13:31:42 +01:00
White
b50a256581 Submodule update 2016-09-17 23:08:49 +09:30
White
6b41d96a99 Another submodule update for a real build fix 2016-09-16 01:15:02 +09:30
White
4612996483 Submodule update with fixed build 2016-09-16 00:42:42 +09:30
White
0848f880f5 Update submodule for 1.3.3.x 2016-09-15 23:31:17 +09:30
ProfessorXZ
4d4679da3b Merge pull request #1282 from ProfessorXZ/icerod-fix
Fixed IceRod not placing ice blocks
2016-09-12 22:25:52 +02:00
ProfessorXZ
9974441868 Added an extra IceRod check to HandleTile 2016-09-12 22:20:06 +02:00
ProfessorXZ
7376ad8b0e Fixed UI issues caused by setting wind speed to high values 2016-09-10 23:35:57 +02:00
ProfessorXZ
775c724b44 Fixed IceRod not placing ice blocks 2016-09-10 22:58:32 +02:00
ProfessorXZ
65c061383e Fixed corrupt packets caused by invalid tile IDs 2016-09-03 14:17:28 +02:00
ProfessorXZ
1316c71a4c UpdateItemDrop packet now points to HandleItemDrop instead 2016-09-03 14:15:26 +02:00
ProfessorXZ
dd50d41f2e Fix item duplication caused by range checks & netIDs. Fixes #1162 2016-09-03 14:15:26 +02:00
White
4dca73a6cc Merge pull request #1272 from ProfessorXZ/handletile-fix
Tile packet validation
2016-09-03 21:43:59 +09:30
ProfessorXZ
f2cc3ce89f Remove unnecessary code from HandleTile() 2016-09-03 14:08:09 +02:00
ProfessorXZ
c305b36168 Fix explosives range checks 2016-09-03 14:08:08 +02:00
ProfessorXZ
30fcf83fa1 Clients are no longer able to bypass tile checks 2016-09-03 14:06:27 +02:00
ProfessorXZ
4d98dd4d24 Explosives are no longer blocked by range checks 2016-09-03 14:06:26 +02:00
Rodrigo
60b7e7d574 Merge pull request #1274 from Patrikkk/fix-junctionbox
Fix Junction Box permission issue
2016-09-02 21:54:10 +01:00
Rodrigo
4371775989 Merge pull request #1277 from ProfessorXZ/rest-readendpoint
Added the Registered property to REST's players/read endpoints
2016-09-02 21:52:59 +01:00
Patrikk
38dea6215e Update Changelog. 2016-09-02 18:45:37 +02:00
ProfessorXZ
05a4e025f7 Added the Registered property to REST's players/read endpoints 2016-08-30 09:16:01 +02:00
Patrikk
d326527d75 Fix Junction Box permission issue
Users without `allowclientsideworldedit` permission couldn't hammer and
change direction of Junction Box.
Code tested and functional.
(idk if I did it right tho lol)
2016-08-20 21:06:27 +02:00
Rodrigo
66f5f9f540 Merge pull request #1270 from ProfessorXZ/syncextravalue-validation
SyncExtraValue validation. Fixes #1024
2016-08-18 02:31:30 +01:00
ProfessorXZ
6c0f3ec15d Players are no longer able to place liquids using packet 82. Fixes #1260 2016-08-12 12:28:41 +02:00
ProfessorXZ
e0f17b82ef SyncExtraValue validation. Fixes #1024 2016-08-10 11:25:03 +02:00
White
599b8abe2a Merge pull request #1269 from ProfessorXZ/general-devel
Fix rope placement range checks and DCU not breaking tiles. Fixes #1155 and #1236
2016-08-09 21:21:29 +09:30
ProfessorXZ
a65eb1667d The DCU now breaks tiles properly. Fixes #1155 2016-08-09 13:39:51 +02:00
ProfessorXZ
64f177e68f Fix rope placement range checks. Fixes #1236 2016-08-06 22:54:58 +02:00
Rodrigo
6b0b67f1ca Merge pull request #1268 from ProfessorXZ/general-devel
Fixes #1250
2016-08-06 21:14:24 +01:00
ProfessorXZ
37d9e93e6c Remove redundant region checks 2016-08-02 19:22:47 +02:00
ProfessorXZ
0919641b7f Update ApiVersion 2016-08-02 18:44:19 +02:00
ProfessorXZ
e9d504afd4 Add ItemForceIntoChest hook. Fixes #1250 2016-08-02 18:41:28 +02:00
White
9e71284ff8 Submodule update. API Ticked to v1.2.4 2016-08-02 19:18:19 +09:30
White
b213236a02 Merge pull request #1267 from ProfessorXZ/general-devel
Fixes #1197
2016-08-02 13:50:45 +09:30
ProfessorXZ
952da9609a Fixes #1197 2016-08-01 22:39:01 +02:00
Rodrigo
e5349d95c9 Merge pull request #1266 from ProfessorXZ/general-devel
Fixes #1255
2016-08-01 12:43:12 +01:00
ProfessorXZ
ee6a98eb4e Fixes #1255 2016-08-01 09:35:37 +02:00
White
b4b3ca1b22 Merge pull request #1265 from ProfessorXZ/general-devel
Fixes #1252 and #1160
2016-08-01 13:40:09 +09:30
ProfessorXZ
2f57336fe8 Fixes #1252 and #1160, remove the optional parameter from TSPlayer.SendMessage() 2016-07-31 22:33:53 +02:00
White
1aa430016a Merge pull request #1264 from ProfessorXZ/general-devel
Use packet 107 for sending chat messages
2016-07-29 21:57:20 +09:30
ProfessorXZ
d0d0fae5ca Add an optional parameters to SendMessage(), add more XML comments to TSPlayer 2016-07-29 14:11:19 +02:00
ProfessorXZ
a02bc1012d Increase chat length 2016-07-29 11:28:58 +02:00